ui: 修复按钮变体使用不一致并统一图标按钮交互#192
Merged
ThaddeusJiang merged 2 commits intoMay 10, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 36.18% 38.10% +1.92%
==========================================
Files 119 121 +2
Lines 5441 5647 +206
==========================================
+ Hits 1969 2152 +183
- Misses 3472 3495 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更目标
修复图片详情页图标按钮在 light mode 下风格不一致、hover 反馈不统一的问题,并统一
<.button>的变体/尺寸使用方式,避免语义与 daisyUI 样式混用。主要改动
<button class="btn ...">改为<.button variant="ghost" size="sm">,class 仅保留结构/定位类。assets/css/app.css中对.btn-ghost的自定义覆盖,恢复 daisyUI 默认 ghost 行为。VmemoWeb.CoreComponents.button/1的variant默认值改为nil,允许“普通默认按钮”写法。<.button>误用:把btn-sm改为size="sm",移除<.button class>中重复btn基类。docs/guides/coding/uiux.md,明确variant负责语义,daisyUI class 负责布局/定位等视觉细节。CHANGELOG.md的Unreleased。验证
mix compilemix test风险与说明
btn-circle/btn-square等结构类用法,仅清理语义冲突类(如btn-sm与size混用)。